Rust implementation of "rescript format" #7603
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
There was a problem hiding this comment.
rewatch format --help
thread 'main' panicked at /Users/nojaf/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.31/src/builder/debug_asserts.rs:570:9:
Positional argument `[FOLDER]` *must* have `required(true)` or `last(true)` set because a prior positional argument (`[FILES]...`) has `num_args(1..)`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
There is something weird in the setup here, the help crashes.
Might be related to the files: Vec<string>, but I'm not sure.
cknitt
force-pushed
the
rescript-format-rust
branch
8 times, most recently
from
0e9bb0c to
e276090
Compare
cknitt
force-pushed
the
rescript-format-rust
branch
from
e276090 to
1268640
Compare
There was a problem hiding this comment.
This worked well with --all in my monorepo setup! Great job!
One small thing to follow up on is that rescript format --check without any input doesn’t provide any output. Perhaps we should log a message indicating that no input was found. I encountered this issue when I forgot to include the --all argument, which was a bit confusing at first.
|
Note for the future - we could add an option to also format docstrings, using the new tools format command. |
|
@nojaf Thanks a lot for testing! Could you retry? I now specified that either |
|
Thanks! That worked for me: 
|
Do not forward the
rescript formatcommand to the legacy JS cli anymore, instead implement the functionality natively in Rust.